Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Latest Posts’ componentWillUnmount to the React component #1167

Merged
merged 1 commit into from Jun 14, 2017

Conversation

nb
Copy link
Member

@nb nb commented Jun 14, 2017

It was in the block object and it wasn’t run at all.

It was in the block object and it wasn’t run at all.
@nb nb added [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended labels Jun 14, 2017
@nb nb requested a review from youknowriad June 14, 2017 10:40
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix 👍

@nb nb merged commit ca55b77 into master Jun 14, 2017
@nb nb deleted the fix/componentwillunmount-at-wrong-level branch June 14, 2017 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants