Replaced "MenuGroup" with "NavigableMenu" in Warning Component. (Fixed:#12503)

[iamdharmesh]

Description

Replaced "MenuGroup" with "NavigableMenu" in Warning Component. which get rid of menu group title "More options" and fixes #12503

How has this been tested?

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[jorgefilipecosta]

Thank you for your contribution @iamdharmesh the code and tests look good to me.

Before:

After:

[youknowriad]

This seems like a lower-level component and API-wise it seems better to have a MenuGroup wrapping MenuItems which makes me wonder if we can't just support no passing a label to MenuGroup instead of this?

[iamdharmesh]

@youknowriad Thanks for reviewing. Yes, you are right. better to use MenuGroup without label as NavigableMenu is lower-level component. I will make this change soon.

[afercia]

@youknowriad a MenuGroup without label will produce a NavigableMenu with an aria-labelledby attribute that points to nothing. That's against the ARIA spec, will be reported by accessibility automated tools as an error, and might confuse assistive technologies. (Edit: to be more clear: it's basically equivalent to an empty label element).

Also, I can understand high-level argumentations but I don't see the need to have a wrapping <div> element in the DOM that doesn't do anything.

I'd say either the MenuGroup should be changed to not render an aria-labelledby attribute if the "label" element it points to is absent, or the NavigableMenu menu should be made a full citizen "high level" component.

[youknowriad]

I'd say either the MenuGroup should be changed to not render an aria-labelledby attribute if the "label" element it points to is absent

This is what I had on my mind. People shouldn't have to think too much to understand how to use a given component.

[iamdharmesh]

@youknowriad I have made aria-labelledby rendering conditional. can you please check.

[youknowriad]

Code wise, this looks good. Can we get another check after the recent changes?