New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wp-settings permissions #13539

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@nosolosw
Copy link
Member

nosolosw commented Jan 28, 2019

This PR fixes an error with the ./bin/setup-environment.sh command by setting the wp-settings.php permissions to something wp-cli core update won't complain about.

Description

Upon exectuion, I've got the following error:

The update cannot be installed because we will be unable to copy some files. This is usually due to inconsistent file permissions.: wp-settings.php

screenshot from 2019-01-25 11-21-46

It looks like the WordPress core update can't proceed due to wp-settings.php permissions.

Test

Executing the command and check that it's able to upgrade to latest WordPress.

I've done this by trying a fresh start (removed docker images and containers, cloned repo, and executed ./bin/setup-environment.sh command), but if you have a WordPress version < 5.0.3 as the offending line is the core update command.

@nosolosw nosolosw requested a review from WordPress/gutenberg Jan 28, 2019

@nosolosw nosolosw self-assigned this Jan 28, 2019

@nosolosw nosolosw added this to the 5.0 (Gutenberg) milestone Jan 28, 2019

@mkaz

mkaz approved these changes Jan 28, 2019

Copy link
Member

mkaz left a comment

Looks good, works for me 👍

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Jan 28, 2019

Yes, it should be okey. I hope we find a bit better way to set permissions for all files in the long run. I personally did the same tweak a few weeks back 😅

@nosolosw nosolosw merged commit 190ce7f into master Jan 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nosolosw nosolosw deleted the fix/wp-settings-permissions branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment