Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color palette settings button hover tootlip fix. #14693

Merged
merged 1 commit into from Apr 10, 2019
Merged

Color palette settings button hover tootlip fix. #14693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/components/src/color-palette/style.scss
View file
Open in desktop
Expand Up @@ -47,6 +47,8 @@ $color-palette-circle-spacing: 14px;
&.is-active {
box-shadow: inset 0 0 0 4px;
border: $border-width solid $dark-gray-400;
position: relative;
z-index: 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen - should there be special handling for z-index used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My impression is that's always good. But I'm honestly not confident, sometimes a z index of 1 is just to elevate a child in a context that isn't subject to the mess it can otherwise create. I know @aduth has thoughts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to him then :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My impression has been to always use _z-index function for any z-index, with the mapping serving as a centralized authority to serve in proactively avoiding aggressively and endlessly increasing a z-index value to "combat" others.

https://github.com/WordPress/gutenberg/blob/master/assets/stylesheets/_z-index.scss

But:

  1. For a case like this, where the value is 1, perhaps it's reasonable to make exceptions
  2. In any case, we don't codify this guideline one way or the other. Whatever we decide, it ought to be written down, e.g. coding-guidelines.md document


& + .dashicons-saved {
position: absolute;
Expand Down