Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified best practices pertaining to Color Palette values #15006

Merged

Conversation

@nickylimjj
Copy link
Contributor

commented Apr 17, 2019

Description

Clarified the name, slug and color values and defined the best practices to use them.

Fixes #14989

How has this been tested?

N/A

Screenshots

N/A

Types of changes

Documentation Update

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Update docs/designers-developers/developers/themes/theme-support.md
@aduth's review

Co-Authored-By: nickylimjj <nickylimjj.nl@gmail.com>
@afercia
Copy link
Contributor

left a comment

Thanks @nickylimjj ! Combined with the examples above, the new text perfectly clarifies the intended usage. I'd just suggest to try to address the case of dynamic values mentioned in the issue, which is what happens for example with Twenty Nineteen:

it may be good to include guidance around dynamic values (such as those sourced from a site option). For example, while not all dynamic values could be described programmatically, it may be advisable to provide meaningful names for at least the default values when applicable.

@aduth aduth merged commit 77b8234 into WordPress:master May 2, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.