Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date: Add test that ordinal suffix works. #15227

Closed
wants to merge 1 commit into from
Closed

Date: Add test that ordinal suffix works. #15227

wants to merge 1 commit into from

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Apr 26, 2019

Fixes #15221

Everything below is TBD since this is just a WIP for now.

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@iandunn iandunn added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Date /packages/date labels Apr 26, 2019
@iandunn iandunn self-assigned this Apr 26, 2019
@iandunn
Copy link
Member Author

iandunn commented Apr 29, 2019

🤔 I'm a bit stumped here. I can't think of why the tests in 054c5d3 pass, but the bug is reproducible in the console.

@gziolo gziolo added Needs Dev Ready for, and needs developer efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. and removed Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Oct 21, 2019
Base automatically changed from master to trunk March 1, 2021 15:42
@iandunn
Copy link
Member Author

iandunn commented Mar 24, 2022

Superceded by #39670

@iandunn iandunn closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iandunn iandunn

Labels
[Package] Date /packages/date [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ordinal suffix token does not work in wp.date.format
2 participants
@iandunn @gziolo