Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show side inserter on the last empty paragraph #15864

Merged
merged 3 commits into from Jun 6, 2019

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented May 28, 2019

This is a proposal to try to tweak the block inserter visibility. Some feedback suggest that it's not always clear how to add blocks/content.

in this PR, I'm trying to give more visibility to the side block inserter on the last paragraph of the post content. Also when focusing "empty paragraphs", we always show the inserter.

@youknowriad youknowriad force-pushed the try/always-show-side-appender branch from 8f63467 to 2ff6160 Compare May 28, 2019 15:13
@mtias
Copy link
Member

mtias commented May 28, 2019

This is looking better. A few points:

  • Let's keep the quick-shortcuts separate until we figure out their role.
  • When you hit enter on a paragraph block, we should still show the + on the new line.

@mtias mtias added the [Feature] Inserter The main way to insert blocks using the + button in the editing interface label May 29, 2019
@jasmussen
Copy link
Contributor

I appreciate this effort, and would echo Matías thoughts: the quick shortcuts don't shine so maybe keep those as they were until we figure something better. Plus, consistency is good.

With that in place, this change seems like it could be a good way to move us forward with making it easy to insert blocks between content and at the end of content. Despite my desire to use Enter as the primary way to do so, this has worked less well in practice than I'd hoped. And I do prefer this side inserter over the sibling inserter, still :D

That said, this still feels sort of like a half-step. I suspect that it would be good for us to continue to think about more profound steps to make it simple to append content. I imagine answers might even present themselves more clearly if/when block areas becomes more of a thing.

@youknowriad youknowriad force-pushed the try/always-show-side-appender branch from 2f58034 to 34cb602 Compare May 31, 2019 11:59
@youknowriad youknowriad marked this pull request as ready for review May 31, 2019 12:01
@youknowriad
Copy link
Contributor Author

The shortcuts change was unintended :)
I made some adjustments, let me know how it feels.

@youknowriad youknowriad added the Needs Design Feedback Needs general design feedback. label May 31, 2019
@youknowriad youknowriad self-assigned this May 31, 2019
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels good to me:

Screen Shot 2019-06-04 at 1 31 43 PM

The only sort of awkward part is when you have two empty paragraphs in a row, you get double add buttons on hover. I think that's okay though:

paragraph

I also tried on columns  — if you manually add a bunch of empty paragraph blocks, they'll all have Add buttons too. But this seems fine as well:

Screen Shot 2019-06-04 at 1 34 23 PM

Sounds like both of the points from @mtias have been addressed, so I think this is good to go for now. I agree with @jasmussen though that we should continue thinking up ways to improve this moving forward.

@kjellr kjellr removed the Needs Design Feedback Needs general design feedback. label Jun 4, 2019
@youknowriad youknowriad force-pushed the try/always-show-side-appender branch from 34cb602 to 93d6a78 Compare June 6, 2019 10:38
@youknowriad youknowriad merged commit 3c10eaa into master Jun 6, 2019
@youknowriad youknowriad deleted the try/always-show-side-appender branch June 6, 2019 11:10
@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants