Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add improved "Group" and "Ungroup" icons #16001
requested review from
Jun 5, 2019
referenced this pull request
Jun 5, 2019
These are nice, and definitely good enough to ship. No objections.
Since you ask, I do kind of wish the "ungroup" had a more direct relation to group, kind of like how link and unlink have in the material set:
I don't know that the diagonal cross over the group would work here, as it seems so destructive. But I do like the connection between the two. It's also interesting to see the noun project's page for this term: https://thenounproject.com/term/ungroup/ — lots of different interpretations.
But those are mostly musings, and one should be careful with those because otherwise things can devolve into fence painting. The truth is, these icons are good, and are going to be shown next to labels, so let's ship it. But lets also be open to shower-ideas for futher improvements, should such be possible!
Yeah, fully agree. :/ I couldn't quite get that crossed-out approach to work here. But I think we can sort this out in another round though.
Anyway, thanks folks! I'll merge these in.