Added ability to filter latest posts by author

[pstonier]

Description

Added dropdown to select author to filter the latest posts in the Latest Posts block.

How has this been tested?

Locally.

Screenshots

Types of changes

• Added AuthorSelect Component to QueryControls based on the CategorySelect Component
• Added users attribute to LatestPosts
• LatestPosts now fetches a user list to populate the dropdown like categories

Checklist:

• [ X ] My code is tested.
• [ X ] My code follows the WordPress code style.
• [ X ] My code follows the accessibility standards.
• [ X ] My code has proper inline documentation.
• [ n/a ] I've included developer documentation if appropriate.

[talldan]

Thanks for working on this @pstonier!

The PR was discussed in a core-editor triage (https://wordpress.slack.com/archives/C02QB2JS7/p1562825386362400 - link requires slack sign up)

We decided to switch the label to Needs Design Feedback. Firstly we felt technical feedback can be provided through the normal code review process. Secondly, it'd be good to understand the motivation behind this PR (as there's no linked issue) and to make sure the UI is implemented in the right way in terms of design and behaviour of the dropdown.

[pstonier]

All sounds good. From the motivation factor: we had been working on a page that was a bio about some of our consultants and needed a way to list the articles they'd authored. I had expected it to be an available filter option and when I found that it wasn't, I found my way around to adding it.

Example Page

[draganescu]

This PR effectively copies the same logic as the category filter and from my tests it appears that it works correctly. I do not approve only because of the "Needs design feedback" label, but my opinion is that we go ahead with it.

[paaljoachim]

This feature seems straight forward to me.

Can some design folks add a comment please? As it would be nice to get it code reviewed and merged. @karmatosed @mapk @kjellr @jasmussen @melchoyce

[jasmussen]

About to do some travelling so can't review in depth. But based on the screenshots alone, this seems good. It's an advanced feature, so it's in the sidebar, and it's a dropdown like the others. 👍 👍

[paaljoachim]

This PR looks ready for a final code review and merge. Thanks!
@talldan

[draganescu]

In the mean time I've added #20415 implementing the same thing, with the hope of getting a faster course :) @pstonier would you look and either move this or that one towards a merge?

[mapk]

I just tested this today and it's working as expected. I like that I'm able to filter the posts by author now! Thanks. I'm approving from a design perspective.

One thing to note is now that I can filter by Author, I'd like a toggle to show the author which should probably exist here:

Of course, don't let that hold up this PR.

[pstonier]

I just tested this today and it's working as expected. I like that I'm able to filter the posts by author now! Thanks. I'm approving from a design perspective.

One thing to note is now that I can filter by Author, I'd like a toggle to show the author which should probably exist here:

Of course, don't let that hold up this PR.

I like that idea and have updated the code to add that.

[draganescu]

@pstonier @mapk #20595 adds the "Show post author" toggle in the inspector. I have not re-reviewed this yet (except one comment) to account for the new thing but will do.

[mapk]

When the code is dialed in again and you'd like another review, just ping me. @draganescu thanks for stepping in to help.

[draganescu]

Howdy @pstonier ,

Trying to test this, setting show author option I get:

TypeError: post.author_info is undefined edit.js:453:15

and the block crashes.

Also a rebase would be in order.

[pstonier]

Howdy @pstonier ,

Trying to test this, setting show author option I get:

TypeError: post.author_info is undefined edit.js:453:15

and the block crashes.

Also a rebase would be in order.

Thanks. I have fixed this and rebased.

[draganescu]

I have tested this and works pretty well. Since we're only adding new data to the block we shouldn't need a deprecation function, testing a previously created block with this PR updated with no issues.

Great job @pstonier !

[pstonier]

Thank you for all the help!