Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make tables accessible at high zoom levels #16324
Partially fixes #15346
In order for wide tables to be scrollable at small breakpoints and/or high zoom levels, I have added a
How has this been tested?
Tested at high zoom levels on Chrome, Firefox, Safari (Mac) and IE (Windows 7 and 10).
Types of changes
Bug fix (non-breaking change which fixes an issue)
requested review from
Jun 27, 2019
Just summarising some of the positives and negatives of the wrapping div:
Looking at some other products:
Re some of @talldan 's pros and cons:
Overall, I'm still for making this change as in my opinion the usability benefits outweigh the costs. But look forward to hearing further discussion points
Jul 9, 2019
@tellthemachines thanks for working on this, works great!
A while ago, we've implemented a similar solution at Yoast, with some additional visual improvements. I'm not saying those are necessarily good for Gutenberg, but I'd like to hear your thoughts and have some design feedback /Cc @mapk. Conversation can continue also on closed issues/PRs
Basically, in our implementation we're trying to solve a few issues:
All these three things kick in only when there's not enough space to display the table entirely so there's some width/viewport JS calculation running behind the scenes.
The table while scrolling horizontally and the scrollbar becomes visible:
When there's enough space, all the visual indicators are not displayed:
Any thoughts more than welcome!