Date/Time picker: ensure hour/minute fields are always shown left to right #16375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsilverstein
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
There was a problem hiding this comment.
Hi @adamsilverstein, in my tests, with these changes the design of the am/pm buttons gets broken in RTL languages:
I think if we apply the direction style to the class components-datetime__time-field-time instead of components-datetime__time-field the problem gets solved.
|
@jorgefilipecosta Thanks for testing, not sure how I missed that :) Fixed in 683bf21, can you please re-test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where right to left languages showed the hour and minute fields reversed, with the minutes on the left instead of the hours.
Fixes #16373.
Description
CSS change: set the
directionfor the.components-datetime__time-fieldclass.How has this been tested?
Published a post after setting my profile to use Hebrew.
Verified the hour field shown to the left of the minute field.
Screenshots
After this PR, my post published at 8:44am shows correctly in an RTL language:
Types of changes
CSS: set the time field order to ltr regardless of page direction.
Checklist: