Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tapping on an empty editor area creates a new paragraph block #16439

Merged
merged 2 commits into from Jul 8, 2019
Merged

Tapping on an empty editor area creates a new paragraph block #16439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbfe756
Create block list tappable footer which creates empty paragraph block
marecar3 Jul 5, 2019
419d91e
Merge branch 'master' into rnmobile/tapping-on-an-empty-editor-area-c…
marecar3 Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/block-editor/src/components/block-list/index.native.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
* External dependencies
*/
import { identity } from 'lodash';
import { Text, View, Keyboard, SafeAreaView, Platform } from 'react-native';
import { Text, View, Keyboard, SafeAreaView, Platform, TouchableWithoutFeedback } from 'react-native';
import { subscribeMediaAppend } from 'react-native-gutenberg-bridge';

/**
Expand Down Expand Up @@ -33,6 +33,7 @@ export class BlockList extends Component {

this.renderItem = this.renderItem.bind( this );
this.renderAddBlockSeparator = this.renderAddBlockSeparator.bind( this );
this.renderBlockListFooter = this.renderBlockListFooter.bind( this );
this.shouldFlatListPreventAutomaticScroll = this.shouldFlatListPreventAutomaticScroll.bind( this );
this.renderDefaultBlockAppender = this.renderDefaultBlockAppender.bind( this );
this.onBlockTypeSelected = this.onBlockTypeSelected.bind( this );
Expand Down Expand Up @@ -171,6 +172,7 @@ export class BlockList extends Component {
title={ this.props.title }
ListHeaderComponent={ this.props.header }
ListEmptyComponent={ this.renderDefaultBlockAppender }
ListFooterComponent={ this.renderBlockListFooter }
/>
<SafeAreaView>
<View style={ { height: toolbarHeight } } />
Expand Down Expand Up @@ -242,6 +244,17 @@ export class BlockList extends Component {
);
}

renderBlockListFooter() {
const paragraphBlock = createBlock( 'core/paragraph' );
return (
<TouchableWithoutFeedback onPress={ () => {
this.finishBlockAppendingOrReplacing( paragraphBlock );
} } >
<View style={ styles.blockListFooter } />
</TouchableWithoutFeedback>
);
}

renderHTML() {
return (
<HTMLTextInput { ...this.props } parentHeight={ this.props.rootViewHeight } />
Expand Down
4 changes: 4 additions & 0 deletions packages/block-editor/src/components/block-list/style.native.scss
View file
Open in desktop
Expand Up @@ -73,3 +73,7 @@
.blockHolderFocused {
border-color: $gray-lighten-30;
}

.blockListFooter {
height: 80px;
}