Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClipboardButton Component: Add description and image #16758

Merged
merged 2 commits into from Aug 8, 2019

Conversation

cburton4
Copy link
Contributor

Description

Added a description of the ClipboardButton component as well as an image.

@davewhitley davewhitley added [Type] Developer Documentation Documentation for developers Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. labels Jul 25, 2019
@davewhitley davewhitley added this to Needs review in Component Audit Jul 25, 2019
@benhuberman
Copy link

Suggested tweak:

With a clipboard button, users copy text (or other elements) with a single click or tap.

The original phrasing works, too, but in general we're trying to move away from language like "allows"/"enables"/etc. and into more direct-action descriptions.

@cburton4
Copy link
Contributor Author

Suggested tweak:

With a clipboard button, users copy text (or other elements) with a single click or tap.

The original phrasing works, too, but in general we're trying to move away from language like "allows"/"enables"/etc. and into more direct-action descriptions.

Sounds good. I'll update that now.

Edited copy to remove language like, "allow."
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ Looks good! Thanks, @cburton4!

@kjellr kjellr merged commit 44c9ec0 into WordPress:master Aug 8, 2019
Component Audit automation moved this from Needs review to Done Aug 8, 2019
@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019
gziolo pushed a commit that referenced this pull request Aug 29, 2019
* ClipboardButton Component: Add description and image

* Copy tweak

Edited copy to remove language like, "allow."
gziolo pushed a commit that referenced this pull request Aug 29, 2019
* ClipboardButton Component: Add description and image

* Copy tweak

Edited copy to remove language like, "allow."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. [Type] Developer Documentation Documentation for developers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants