Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClipboardButton Component: Add description and image #16758

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@cburton4
Copy link
Contributor

commented Jul 25, 2019

Description

Added a description of the ClipboardButton component as well as an image.

@benhuberman

This comment has been minimized.

Copy link

commented Jul 25, 2019

Suggested tweak:

With a clipboard button, users copy text (or other elements) with a single click or tap.

The original phrasing works, too, but in general we're trying to move away from language like "allows"/"enables"/etc. and into more direct-action descriptions.

@cburton4

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

Suggested tweak:

With a clipboard button, users copy text (or other elements) with a single click or tap.

The original phrasing works, too, but in general we're trying to move away from language like "allows"/"enables"/etc. and into more direct-action descriptions.

Sounds good. I'll update that now.

Copy tweak
Edited copy to remove language like, "allow."
@kjellr
kjellr approved these changes Aug 8, 2019
Copy link
Contributor

left a comment

⭐ Looks good! Thanks, @cburton4!

@kjellr kjellr merged commit 44c9ec0 into WordPress:master Aug 8, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

Component Audit automation moved this from Needs review to Done Aug 8, 2019

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019

gziolo added a commit that referenced this pull request Aug 29, 2019
ClipboardButton Component: Add description and image (#16758)
* ClipboardButton Component: Add description and image

* Copy tweak

Edited copy to remove language like, "allow."
gziolo added a commit that referenced this pull request Aug 29, 2019
ClipboardButton Component: Add description and image (#16758)
* ClipboardButton Component: Add description and image

* Copy tweak

Edited copy to remove language like, "allow."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.