[RNMobile] Refactor BlockToolbar follow-up PR #16906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tug
added
the
Mobile App - i.e. Android or iOS
mchowning
reviewed
Aug 5, 2019
| @@ -158,6 +160,7 @@ export default compose( [ | |||
| } ), | |||
| withDispatch( ( dispatch ) => { | |||
| const { | |||
| clearSelectedBlock, | |||
There was a problem hiding this comment.
It looks like clearSelectedBlock from core/editor just calls through to core/block-editor with a deprecation warning that shows up as a Yellow Box warning. Sounds like we should just get this directly from core/block-editor instead of via core/editor.
There was a problem hiding this comment.
I think we also need to update header-toolbar: https://github.com/WordPress/gutenberg/pull/16906/files#diff-dbd7e14b9675d5446422c008453093bbR91. Sorry I didn't realize that before.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Keyboard is already hidden with clearSelectedBlock * Hide Keyboard when switching mode * require clearSelectedBlock from core/block-editor instead of core/editor * require clearSelectedBlock from core/block-editor instead of core/editor
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Keyboard is already hidden with clearSelectedBlock * Hide Keyboard when switching mode * require clearSelectedBlock from core/block-editor instead of core/editor * require clearSelectedBlock from core/block-editor instead of core/editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some minor issues with #16677
How has this been tested?
Tested with wordpress-mobile/gutenberg-mobile#1247
Types of changes
UX changes:
Checklist: