Chore: Code improvements to block PHP files. #17288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
jorgefilipecosta
requested review from
ajitbohra,
Soean and
talldan
as code owners
talldan
approved these changes
Sep 2, 2019
talldan
deleted the
update/chore/code-improvements-in-block-PHP-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies simple changes to remove useless assignments in some block PHP files (where we can return immediately). The PR also applies changes to return immediately and void nested if-else in the archives block.
How has this been tested?
This is just a simple code change. I just did some smoke tests in the tested block (special emphasize on archive block).