Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Code improvements to block PHP files. #17288

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 31, 2019

Description

This PR applies simple changes to remove useless assignments in some block PHP files (where we can return immediately). The PR also applies changes to return immediately and void nested if-else in the archives block.

How has this been tested?

This is just a simple code change. I just did some smoke tests in the tested block (special emphasize on archive block).

@talldan
talldan approved these changes Sep 2, 2019
Copy link
Contributor

left a comment

I tested the blocks and they all seem to be working well. Nice one 👍

@talldan talldan merged commit f1b2f29 into master Sep 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the update/chore/code-improvements-in-block-PHP-files branch Sep 2, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.