Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Add WordPress folder to the list of ignores in configs #17296

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@gziolo
Copy link
Member

commented Sep 2, 2019

Description

Follow-up for #17004 where wp-scripts env install adds wordpress folder with the local instance of WordPress.

This PR adds this new wordpress folder to all recommended configs in @wordpress/scripts to ensure that this folder is ignored and doesn't trigger any false alarms. This is quite similar to what happens in Gutenberg with the config overrides:

wordpress

wordpress

Testing

Basically all the following should work as before:

npm run lint-css
npm run lint-js
npm run lint-pkg-json
npm run test-e2e
npm run test-unit

I did some testing by adding files with failures to the wordpress folder.

@gziolo gziolo requested review from ajitbohra, nerrad, ntwb and youknowriad as code owners Sep 2, 2019
@gziolo gziolo force-pushed the update/scripts-ignore branch from 16e4f20 to 0f28a37 Sep 2, 2019
@gziolo gziolo requested a review from talldan as a code owner Sep 2, 2019
.stylelintignore Show resolved Hide resolved
@gziolo gziolo requested a review from pento Sep 2, 2019
@gziolo gziolo self-assigned this Sep 2, 2019
@ntwb
ntwb approved these changes Sep 2, 2019
@gziolo gziolo referenced this pull request Sep 2, 2019
2 of 5 tasks complete
@pento
pento approved these changes Sep 3, 2019
Copy link
Member

left a comment

👍🏻

@gziolo gziolo merged commit 6e85a0b into master Sep 3, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@gziolo gziolo deleted the update/scripts-ignore branch Sep 3, 2019
@gziolo gziolo added this to the Gutenberg 6.5 milestone Sep 3, 2019
ntwb added a commit that referenced this pull request Sep 3, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.