Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add the docs for the onClose property. #17403

Merged
merged 1 commit into from Sep 13, 2019
Merged

Docs: Add the docs for the onClose property. #17403

merged 1 commit into from Sep 13, 2019

Conversation

peterwilsoncc
Copy link
Contributor

Description

Adds documentation for the onClose property of MediaUpload.

How has this been tested?

Doc change only, no code.

I have confirmed the property exists locally.

Screenshots

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@peterwilsoncc peterwilsoncc added [Type] Developer Documentation Documentation for developers [Feature] Media Anything that impacts the experience of managing media labels Sep 11, 2019
talldan
talldan approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this!

@talldan talldan merged commit 466a0e7 into master Sep 13, 2019
@talldan talldan deleted the add/document-media-upload-onclose branch September 13, 2019 21:09
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@peterwilsoncc peterwilsoncc

Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 6.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterwilsoncc @talldan @youknowriad