Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add the docs for the `onClose` property. #17403

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@peterwilsoncc
Copy link
Contributor

commented Sep 11, 2019

Description

Adds documentation for the onClose property of MediaUpload.

How has this been tested?

Doc change only, no code.

I have confirmed the property exists locally.

Screenshots

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Copy link
Contributor

left a comment

Looks great, thanks for adding this!

@talldan talldan merged commit 466a0e7 into master Sep 13, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the add/document-media-upload-onclose branch Sep 13, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.