Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Add Component Storybook. #17475

Merged
merged 9 commits into from Oct 4, 2019
Merged

Framework: Add Component Storybook. #17475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f3d9c10
Framework: Add Component Storybook.
epiqueras Sep 18, 2019
21f8152
Framework: Add storybook to Netlify deploy.
epiqueras Sep 19, 2019
c5140f6
Framework: Add Storybook Docs.
epiqueras Sep 24, 2019
f6c9852
Framework: Add a stand-alone Storybook documentation page example.
epiqueras Sep 24, 2019
abd6a40
Components: Add custom Babel config for storybook.
epiqueras Sep 24, 2019
6786bd2
Framework: Update lockfile and playground script name.
epiqueras Oct 2, 2019
37bbeb0
Framework: Update lockfile and ignore Storybook files for publishing.
epiqueras Oct 3, 2019
032831a
Travis: Only deploy once per build, not per job.
epiqueras Oct 4, 2019
edd53d4
Framework: Update lockfile.
epiqueras Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
View file
Open in desktop
Expand Up @@ -122,6 +122,7 @@ module.exports = {
excludedFiles: [
'**/*.@(android|ios|native).js',
'**/@(benchmark|test|__tests__)/**/*.js',
'**/{storybook,stories}\/*\.js',
],
},
{
Expand Down
29 changes: 16 additions & 13 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -195,18 +195,21 @@ jobs:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 3' < ~/.jest-e2e-tests )

- stage: deploy
name: Deploy Playground
env: INSTALL_WORDPRESS=false
before_deploy:
- npm install
- npm run playground:build -- --public-url '/gutenberg'
- npm run design-system:build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like with the changes applied in this PR, design-system:build will run twice on Travis:

"playground:build": "npm run build:packages && parcel build playground/src/index.html -d playground/dist && npm run design-system:build",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17818

deploy:
provider: pages
skip_cleanup: true
github_token: $GITHUB_TOKEN
keep_history: true
local_dir: playground/dist
on:
branch: master

allow_failures:
- name: JavaScript native mobile tests

before_deploy:
- npm install
- npm run playground:build -- --public-url '/gutenberg'

deploy:
provider: pages
skip_cleanup: true
github_token: $GITHUB_TOKEN
keep_history: true
local_dir: playground/dist
on:
branch: master
2 changes: 1 addition & 1 deletion docs/contributors/getting-started.md
View file
Open in desktop
Expand Up @@ -65,6 +65,6 @@ You can also type `npm run package-plugin` which will run the two commands above

The Gutenberg repository also includes a static Gutenberg playground that allows testing and developing in a WordPress-agnostic context. This is very helpful for developing reusable components and trying generic JavaScript modules without any backend dependency.

You can launch the playground by running `npm run playground:start` locally. The playground should be available on [http://localhost:1234](http://localhost:1234).
You can launch the playground by running `npm run playground:dev` locally. The playground should be available on [http://localhost:1234](http://localhost:1234).

You can also test the playground version of the current master branch on GitHub Pages: [https://wordpress.github.io/gutenberg/](https://wordpress.github.io/gutenberg/)
3 changes: 2 additions & 1 deletion lerna.json
View file
Open in desktop
Expand Up @@ -7,7 +7,8 @@
"ignoreChanges": [
"**/benchmark/*.js",
"**/CHANGELOG.md",
"**/test/**"
"**/test/**",
"**/{storybook,stories}/**"
],
"packages": [
"packages/*"
Expand Down