Add end to end test to the date picker UI next&previous month butons #17490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Automated Testing
jorgefilipecosta
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
talldan
as code owners
epiqueras
approved these changes
Sep 19, 2019
| } from '@wordpress/e2e-test-utils'; | ||
|
|
||
| describe( 'Scheduling', () => { | ||
| beforeEach( async () => { |
There was a problem hiding this comment.
beforeEach(createNewPost) also works.
jorgefilipecosta
force-pushed
the
add/end-to-end-test-date-pciker-ui
branch
from
bd61c5e
to
fb1248c
Compare
jorgefilipecosta
force-pushed
the
add/end-to-end-test-date-pciker-ui
branch
from
fb1248c
to
27a86b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an end 2 end test that makes sure when next&previous month buttons are clicked the focus stays on the date picker interface and consequently the popover stays open.
This makes sure that the fix added in PR #17201 does not regress.
The post scheduler mechanism is not covered with end 2 end tests I plan to follow up with more tests on this file.
How has this been tested?
I verified the end to end test passes:
I reverted PR #17201 and verified the end 2 end test fails: