[Tiny PR] RichText: correctly update value after undo #17840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
talldan
as code owners
|
Seems to be an issue with RichText not applying the change. |
|
Seems to be introduced in #15496. |
ellatrix
requested review from
daniloercoli,
etoledom,
jorgefilipecosta and
SergioEstevao
as code owners
ellatrix
changed the title
ellatrix
changed the title
ellatrix
added
[Package] Rich text
mcsf
approved these changes
Oct 9, 2019
| if ( shouldReapply ) { | ||
| this.value = value; | ||
| this.record = this.formatToValue( value ); | ||
| this.record.start = selectionStart; | ||
| this.record.end = selectionEnd; | ||
|
|
||
| updateFormats( { |
There was a problem hiding this comment.
So was updateFormats mutating the record back to a state with the previous formats? Is that it?
There was a problem hiding this comment.
Yes, that's it. :) I'm not sure why it's here, I probably made a mistake.
|
Thanks for the review! |
gziolo
pushed a commit
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #17839. RichText is not removing formatting after undo. This is caused by
updateFormats, which seems to be called in that place for no reason. Looks like I made a mistake calling it there.How has this been tested?
Screenshots
Types of changes
Checklist: