Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update data package README #17878

Merged
merged 1 commit into from Nov 14, 2020
Merged

Docs: update data package README #17878

merged 1 commit into from Nov 14, 2020

Conversation

adekbadek
Copy link
Contributor

@adekbadek adekbadek commented Oct 10, 2019

When starting development with @wordpress/data and reading the "Comparison with Redux" section I was surprised that a package would be created just to "establish a modularization pattern" and "codify conventions".
For me the selling point was the built-in async data flow handling, which is visible in the examples, but missing in the section that people coming from from redux might read first.

Add a paragraph in Comparison with Redux section, explaining that 
async side-effects solutions are built-in.
@gziolo gziolo added [Type] Developer Documentation Documentation for developers First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Data /packages/data labels Oct 10, 2019
@gziolo
Copy link
Member

gziolo commented Oct 10, 2019

Thanks for sharing your feedback. I agree that we should expand this section as it has changed a lot since it was authored 👍

@nerrad, we should also include a note about hooks and make them more prominent than HOCs. This will make this description even more appealing.

@gziolo gziolo requested a review from epiqueras October 10, 2019 09:27
@nerrad
Copy link
Contributor

nerrad commented Oct 10, 2019

Ya, I agree, it would be good to give the hooks more visibility here.

@gziolo gziolo merged commit 884ff88 into WordPress:master Nov 14, 2020
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Data /packages/data [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants