Update: Use gradient classes in cover block #18590
Conversation
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
requested review from
ajitbohra,
Soean and
talldan
as code owners
| @@ -34,6 +36,8 @@ export default function save( { attributes } ) { | |||
| minHeight, | |||
| } = attributes; | |||
| const overlayColorClass = getColorClassName( 'background-color', overlayColor ); | |||
| const gradientClass = __experimentalGetGradientClass( gradient ); | |||
There was a problem hiding this comment.
__experimentalGetGradientClass and getColorClassName
Some naming inconsistencies here :) Also when do you think we should make the "gradients" stable?
There was a problem hiding this comment.
__experimentalGetGradientClass and getColorClassName
Some naming inconsistencies here :)
Hopefully, it is experimental so we can correct the inconsistency.
Also when do you think we should make the "gradients" stable?
I think first we should merge the custom gradient picker, and stabilize its UI.
It seems we may end up with tabs to separate solid colors and gradients as @mtias suggested #17603 (comment).
When we go for that design a gradient hook may not make sense and it may be better to add gradient support in the colors hook (essentially move the hook we have now into useColors) so we can return the tabbed UI there and remove the need for blocks to add it.
There was a problem hiding this comment.
agreed about the hooks, but for the theme support, I think we can probably remove the experimental flag from there unless you think the format is subject to change?
jorgefilipecosta
deleted the
update/use-gradient-classes-in-cover-block
branch
Description
This PR makes cover block use gradient classes. It was not possible to do it from the start because the block needed to be refactored into a functional component.
cc: @youknowriad
How has this been tested?
I added a cover block with a simple gradient background.
I added a cover block with an image and gradient overlay.
I added a video block with an image and gradient overlay.
I published the post with the three blocks and verified it looked as expected. On the code editor, the editor used classes and not inline styles to specify the gradient.