Fix: Focal points are not rounded #18765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten,
talldan and
youknowriad
as code owners
youknowriad
approved these changes
Nov 27, 2019
We set a relative position in percentage rounding to two digits makes the percentages integer. The way we set the focus point in a small area probably does not provide a higher precision anyway. I think this precision should be enough, but let us keep an eye if people notice a difference. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #18665
Currently, the focal point is not rounded. That makes the cover block markup contain attributes and styles with many decimal places.
That precision is not required and rounding to two decimal places makes the markup cleaner and reduces some bytes on each cover block created.
How has this been tested?
I added a cover block with an image background.
I used the focal point picker and changed it using the mouse.
I switched to code editor mode, and verified the attributes and markup contained only two decimal places.