Block Editor: Align Hook: Pass empty deps to useSelect

[aduth]

Follow-up of #18963

This pull request seeks to revise the use of useSelect in the newly-refactored align hook to pass an (empty) dependencies array as the second argument, used as an indicator that the select callback does not use any scoped dependencies. Without this argument, the mapSelect callback would be unnecessarily called on every render.

This is intended as a minor optimization.

Testing Instructions:

Repeat testing instructions from #18963

[gziolo]

Good catch, I think there are more places in the code where 2nd param in useSelect calls isn't provided. Should we update them as well? Do you know if there is an easy way to teach ESLint rule for the React core hooks to work with custom hooks as well? It should help to catch issues like that.

[ellatrix]

I have also forgotten it 🙈

[youknowriad]

Definitely, worth an ESlint rule, I was wrongly assuming it's the default behavior but I do understand why it's not. (values not updated properly as prop changes...)

[aduth]

Glad we're all thinking the same thing 😄

I opened #19007 as another exploration of whether this should be something we do universally:

This follows some discussion at #18960 (comment) and for me is something of a personal study of if and how dependencies should apply to hooks, or if dependencies should always be provided when supported by a hook.

My comment at #14985 (comment) was also related to this, based on the discussion from #18960 (comment), whether react-hooks/exhaustive-deps is meant to do anything on this front (forcing the second parameter).