Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Directory: Use the block's title for alt text on block directory plugin items. #19263

Merged
merged 2 commits into from Dec 23, 2019
Merged

Block Directory: Use the block's title for alt text on block directory plugin items. #19263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18d39b3
Block Directory: Use the block's title to construct an alt text for t…
StevenDufresne Dec 20, 2019
6b307bb
Add an accompanying translator comment to explain the placeholder.
StevenDufresne Dec 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/block-directory/src/components/downloadable-block-header/index.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
* WordPress dependencies
*/
import { Button } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { __, sprintf } from '@wordpress/i18n';

/**
* Internal dependencies
Expand All @@ -15,7 +15,8 @@ function DownloadableBlockHeader( { icon, title, rating, ratingCount, onClick }
<div className="block-directory-downloadable-block-header__row">
{
icon.match( /\.(jpeg|jpg|gif|png)$/ ) !== null ?
<img src={ icon } alt="block icon" /> :
// translators: %s: Name of the plugin e.g: "Akismet".
<img src={ icon } alt={ sprintf( __( '%s block icon' ), title ) } /> :
MarcoZehe marked this conversation as resolved.
Show resolved Hide resolved
<span >
<BlockIcon icon={ icon } showColors />
</span>
Expand Down