Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update downshift dependency to v4.0.5 #19661

Merged
merged 1 commit into from Jan 15, 2020
Merged

Chore: Update downshift dependency to v4.0.5 #19661

merged 1 commit into from Jan 15, 2020

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jan 15, 2020 •
edited

Description

Closes #19644.

This pull request seeks to update the Downshift dependency in packages/components from ^3.3.4 to ^4.0.5.

I followed the workflow described in:
https://github.com/WordPress/gutenberg/tree/master/packages#updating-existing-dependencies

How has this been tested?

Tested in Storybook and it seems to work as before

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@gziolo gziolo self-assigned this Jan 15, 2020
@gziolo gziolo mentioned this pull request Jan 15, 2020
Closed
@gziolo gziolo requested a review from a team January 15, 2020 09:02
@epiqueras epiqueras merged commit d971daf into master Jan 15, 2020
@epiqueras epiqueras deleted the update/downshift-dependency branch January 15, 2020 14:59
@epiqueras
Copy link
Contributor

Thanks!

@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiqueras epiqueras epiqueras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@gziolo gziolo

Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.

Can't upgrade Downshift
3 participants
@gziolo @epiqueras @ellatrix