Framework: Use WHATWG URL in place of legacy url module #19823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Framework
aduth
requested review from
ajitbohra,
ellatrix,
gziolo,
jorgefilipecosta,
nerrad,
ntwb,
Soean,
talldan,
TimothyBJacobs and
youknowriad
as code owners
6 tasks
gziolo
added
the
Backport to WP Beta/RC
gziolo
reviewed
Jan 22, 2020
packages/block-editor/src/utils/transform-styles/transforms/url-rewrite.js
Show resolved
Hide resolved
sgomes
reviewed
Jan 23, 2020
There was a problem hiding this comment.
Great to see Gutenberg moving away from node's url! Great work, @aduth!
I left some comments that may or may not be relevant, depending on what you expect the passed in URLs to be. The URL constructor can only produce absolute URLs, so if you're passing in a non-absolute URL you need to specify a base URL to fill in the gaps, just like you did in getResourcePath. I left comments in other parts of the code, where no base URL was provided.
24 tasks
This was referenced Jan 24, 2020
|
Edit: This branch has been rebased to remove the polyfill code. Related Core Trac ticket for upstream polyfill patch: https://core.trac.wordpress.org/ticket/49360 |
This was referenced Feb 7, 2020
aduth
force-pushed
the
update/node-url-to-native-url
branch
from
c8c0d0a
to
bdddf00
Compare
aduth
removed
the
Backport to WP Beta/RC
aduth
force-pushed
the
update/node-url-to-native-url
branch
from
bdddf00
to
8a6acba
Compare
|
Size Change: -8.78 kB (1%) Total Size: 856 kB
ℹ️ View Unchanged
|
aduth
force-pushed
the
update/node-url-to-native-url
branch
from
8a6acba
to
26a0dbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #13386
Unblocks (maybe): #19816
Closes #19629
This pull request seeks to remove usage of the Node legacy
urlmodule in favor of the WHATWGURLconstructor which is native to both Node.js and modern browsers. A polyfill has been included for unsupported browsers.The proposed advantages here are:
The following bundle size changes have been observed:
block-editorblock-libraryTesting Instructions:
Verify tests pass:
For good measure, verify affected behaviors: