Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Template Validation Improvements #19882

Closed
wants to merge 1 commit into from

Conversation

BE-Webdesign
Copy link
Contributor

@BE-Webdesign BE-Webdesign commented Jan 24, 2020

Description

Template validation for nested templates is currently not working cleanly noted here: #11681. In depth details can be read here: #11681 (comment)

More background:
#3588

Tasks:

    • Perform template validation in the BlockList component.
      • Add the global template settings under the blockListSettings state
      • Local templates should take precedence over the global template.
      • Create logic which also parses the global template given an arbitrary client ID.
    • Remove block validation from the BlockEditorProvider level in favor of 1.
      • Make sure that the notice on invalid template still displays and works properly
    • Remove block validation from InnerBlocks in favor of 1.
    • (future) Create a new way to consume this API in order to power things like isMovable, isLocked, etc. etc. It should be more specific and consistent so that it's easy to modify the block actions available based on the template.

How has this been tested?

Tests in progress...

Screenshots

In progress...

Types of changes

In progress...

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@BE-Webdesign BE-Webdesign added the [Status] In Progress Tracking issues with work in progress label Jan 24, 2020
@BE-Webdesign BE-Webdesign self-assigned this Jan 24, 2020
@BE-Webdesign BE-Webdesign changed the title Placeholder Commit Block Template Validation Improvements Jan 26, 2020
Base automatically changed from master to trunk March 1, 2021 15:43
@BE-Webdesign
Copy link
Contributor Author

Closing as this is long stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant