Scripts: Ensure the default Prettier config is used with lint-js when needed
#20071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
gziolo
requested review from
ajitbohra,
nerrad,
ntwb and
youknowriad
as code owners
gziolo
force-pushed
the
fix/wp-scripts-lint-js-prettier
branch
from
03b458a
to
79c3d6e
Compare
epiqueras
approved these changes
Feb 6, 2020
Co-Authored-By: Enrique Piqueras <epiqueras@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #20036.
wp-scripts lint-jsuses the default Prettier settings if no config is provided in the root of the project. It wasn't the case for Gutenberg because it has Prettier config for IDE integration.This patch adds a fallback for projects who opt-out from defining their own Prettier config and reuses the default one used with
wp-scripts format-jsHow has this been tested?
I removed ESLint config and Prettier config from the root level of Gutenberg and executed:
npm run lint-jsThere were 24 errors reported but they are silenced with the existing ESLint plugin. That confirms that this patch works as intended.
Checklist: