Scripts: Ensure packages-update works with missing dependencies #20408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies` are missing
gziolo
requested review from
ajitbohra,
nerrad,
ntwb and
youknowriad
as code owners
gziolo
added
[Type] Bug
|
@jorgefilipecosta – do you think we can include this simple bug fix/improvement in the Beta 3/npm release? |
|
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
jorgefilipecosta
added
the
Backport to WP 6.6 Beta/RC
jorgefilipecosta
approved these changes
Feb 24, 2020
jorgefilipecosta
changed the title
packages-update work when dependencies or devDependnecies missing
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 24, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 24, 2020
jorgefilipecosta
removed
the
Backport to WP 6.6 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I discovered thed following issue when testing
wp-scripts packages-updatewithgutenberg-examplesrepository:$ npx wp-scripts packages-update /Users/gziolo/Projects/gutenberg-examples/node_modules/@wordpress/scripts/scripts/packages-update.js:19 return Object.keys( packageJSON.dependencies ) ^ TypeError: Cannot convert undefined or null to objectdependencieskey is missing in thepackage.jsoncausing the script to error. The proposed fix mitigates the issue by providing the default value.How has this been tested?
I monkey-patched
node_modulesto use the updated version and tested it in the same repository.Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist: