Block Library: Social Link: Use placeholder for default label #20475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
|
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
mcsf
approved these changes
Feb 26, 2020
aduth
added
the
Backport to WP Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
removed
the
Backport to WP Beta/RC
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20152
This pull request seeks to update the implementation of Social Block to use a placeholder for its default label. Previously, it used string concatenation of "Link to " + the service name. This sort of concatenation can be problematic for translations, especially when a translation would require a reordering of the service name relative to other words in the phrase.
References:
Note: I have assigned this to the "WordPress 5.4 Must Have" project, since this block is newly introduced in WordPress 5.4 and this string may otherwise be problematic to translate. However, it is worth noting that the upcoming 5.4 RC constitutes a string freeze. This change should be considered a string change and would not qualify to be changed after the RC release.
Testing Instructions:
Verify that there are no regressions in the rendering of a Social Link block using the default label.
aria-labelof the WordPress icon is "Link to WordPress"