Polish a few broken things in the sidebar. #20782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some issues with the block sidebar: - The active style looked a bit overwhelming. - The button-group control lacked a little style. - The Width/Height controls for an image were offset. This PR addresses those.
jasmussen
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta and
youknowriad
as code owners
9 tasks
youknowriad
reviewed
Mar 11, 2020
| @@ -20,7 +20,3 @@ | |||
| font-style: italic; | |||
| } | |||
| } | |||
|
|
|||
| .components-base-control + .components-base-control { | |||
There was a problem hiding this comment.
I wonder if we should remove that rule just like that. It has implications on all sidebars (and all other places where we use multiple controls in a row like the entities save modal) (multiple controls in a row) including in third-party blocks.
There was a problem hiding this comment.
I'd rather override it personally where we have horizontal controls today.
There was a problem hiding this comment.
I responded in #20608 (comment) — best I can tell it's either dead code or ill-advised. In all my web-inspecting, the rule was almost always overridden.
The way to space base controls, I would suggest, is simple:
.components-base-control {
margin-bottom: $grid-unit-20;
}
While you can achieve the same with the following:
.components-base-control + .components-base-control {
margin-top: $grid-unit-20;
}
That's a far more roundabout way of doing it. And given margins collapse regardless, the former seems much more the correct way of spacing things.
There was a problem hiding this comment.
I guess the .components-base-control .components-base-control__field bottom padding makes this rule a bit redundant. I'm actually ok removing it now.
There was a problem hiding this comment.
Should we remove the rule from the table block too? (it's overridden there)
There was a problem hiding this comment.
I'll remove it there and ship. Thanks for fast review!
|
Size Change: +109 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Mar 11, 2020
youknowriad
pushed a commit
that referenced
this pull request
Mar 11, 2020
There were some issues with the block sidebar: - The active style looked a bit overwhelming. - The button-group control lacked a little style. - The Width/Height controls for an image were offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some issues with the block sidebar:
This PR addresses those.
Before:
After:
The button-group after:
Before:
After:
Note that I expect all of the above to receive additional polish. #18667 offers additional avenues to refining how each of these controls look, behave, and are positioned well in the sidebar. I consider this PR a minimal first step towards making it less broken, but not the endgame step.