-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Color settings #21326
Merged
Merged
[RNMobile] Color settings #21326
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit
Hold shift + click to select a range
ed821f9
First color picker implementation
lukewalczak f3eb7c9
Rename context provider and consumer
lukewalczak 073650a
Export BottomSheetConsumer
lukewalczak ea04b22
Add first animation
lukewalczak 3e11cf2
Add second animation - layout animation
lukewalczak 67c7892
Add SegmentedControls component
lukewalczak e521c27
Add ColorPalette
lukewalczak e3e9b13
Create ColorIndicator
lukewalczak a11712d
Correct styles file
lukewalczak f20ec02
First main refactor
lukewalczak e4ce3a5
Make SegmentedControls platform specific
lukewalczak 3f124b0
Extract ColorPicker to separate file, update NavigationHeader
lukewalczak b682139
Connect Text color settings
lukewalczak 298dc71
Extract ColorSettings to separate file
lukewalczak 3df7536
Support dark mode in SegmentedControls
lukewalczak d55cbef
Implement CustomSwatch
lukewalczak badf276
Handle closing bottom sheet from picker
lukewalczak 2436753
Theme tweaks
lukewalczak ec94046
Correct palette scroll, some styling fixes, correct isSelected condit…
lukewalczak c37ae2f
Design adjustments
lukewalczak 4726ff3
Animate swatch press
lukewalczak 29c8f8d
Add wrapper for bottom sheet children
lukewalczak 88478fd
Correct animation, bottom sheet, make scrollable area taller
lukewalczak 6933353
Color hex text next to swatch
lukewalczak 8ede0b5
Correct segmented controls
lukewalczak e4c8757
Animate segemented controls
lukewalczak f0f8dd5
Remove hex next to swatch, small improvements
lukewalczak b571fd0
Support hex color copying, change animation duration, fix scrollview
lukewalczak 6581e6e
Adjustments for the largest font sizes
lukewalczak fbb2874
Unblock maxHeight for bottom sheet with color picker
lukewalczak ad5d6a7
Correct impementation to correct transition
lukewalczak 5c7692e
Support android hardware back button in subsheet navigation
lukewalczak eb39721
Remove selecting swatch
lukewalczak f003b34
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak 9e17587
Correct scrolling, border width issue
lukewalczak 8eaccfa
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak 3ded391
Fix lint issues
lukewalczak 1922e9d
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak c4757a5
Add new lib to test setup
lukewalczak a065d33
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak 0f019e6
Colors and outline refactor, creating gradient hoc
lukewalczak 7040712
Navigation refactor, segemented controls refactor
lukewalczak 8eaf90a
ColorPalette fix, correct swatches border color
lukewalczak c127ea1
Move onReplaceSubsheet function to BottomSheet
lukewalczak 28fdfac
Revert UnsupportedFooterControl
lukewalczak 4e682f2
First refactor part
lukewalczak 1c7b7be
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak 15082b9
Small cleanup after merging
lukewalczak ffd5b07
Set colors workaround
lukewalczak de340b3
Correct if-else in setColor
lukewalczak 56b07bc
Refactor footer buttons
lukewalczak 142b0ad
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak 2922555
move color settings to color hook
dratwas 0ca7159
remove separator from last control
dratwas 0311932
Correct animation on Android, remove default color, render text when …
lukewalczak ec16422
Disable flag __experimentalColor in native block which are not suppor…
lukewalczak 5d6d97e
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak f33310d
Remove hoc related to setting gradient
lukewalczak a80f03a
Code clean up
lukewalczak 623163c
Make supporting colors dependent on platform
lukewalczak bfe38fb
Revert changes from button index
lukewalczak 836ca75
Use styles button destructuring
lukewalczak 31fcfec
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak 0c8c886
Another code clean up
lukewalczak 6ab1081
Refactor button styles
lukewalczak b4f3cca
Documented bottom sheet context content
lukewalczak d04348f
Another code clean up
lukewalczak 67b0134
Remove redundant provider export
lukewalczak 84e0331
Refactor color palette
lukewalczak 7cd1875
Refactor: use usePreferredColorSchemeStyle, move subsheets and segmen…
lukewalczak e56bb60
Move default BottomSheet context to separate file
lukewalczak 9e8ba7f
Move function isGradient to utils
lukewalczak 03b69f9
Refactor colorsUtils, unify colors label
lukewalczak 3a674b4
Merge branch 'master' into rnmobile/settings-color-picker
lukewalczak fa36fc3
Correct using colors in reverted Button block
lukewalczak 4c49765
Correct button colors
lukewalczak 92e2c6c
Remove redundant check
lukewalczak File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm wondering if we could change it a bit to block the contrast checking for mobile even if it is set to
true
in props?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add check
isWebPlatform
before eachenableContrastCheking
.