[RNMobile] Dark mode on Android put on the v1.25.0 native release #21352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase
…le/release-v1.25.0-with-dark-mode
hypest
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 884 kB ℹ️ View Unchanged
|
|
I created this PR by branching off the 1.25.0 release branch and merging the Dark Mode's fix branch (from this PR). That had the side effect of pulling in some newer commits after the v1.25.0 cut-off point. Here's the diff. Looking at those commits, only one is native mobile related (the "pre" fix), which happens to already be cherry-picked into the release anyway. In the meantime, people have been manually testing this code (see people's results in GitHub comments here). To avoid disrupting that testing, I think we can let these "extra" commits here to go in, especially since they will actually be reasonably well-tested. |
2 tasks
|
We'll merge this to master and then cherry-pick into the 1.25 native mobile release. cc @SergioEstevao since you're wrangling the release. |
SergioEstevao
added a commit
that referenced
this pull request
Apr 3, 2020
…1352) * Revert revert of dark mode impl * Add pre to list of block wrappers (#21255) * Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase Co-authored-by: Marko Savic <savicmarko1985@gmail.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
6 tasks
SergioEstevao
added a commit
that referenced
this pull request
Apr 3, 2020
* Add pre to list of block wrappers (#21255) * Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase * Fix the TS used for the GB-Mobile project. (#21324) * Fix the TS used for the GB-Mobile project. Make sure only types inside node_modules/@types are used. This avoids TS to find the ../node_modules/@types inside the gb-mobile repo that lives one path level up of gutenberg root. * Framework: Fix configuration spacing * Change to types node. * Revert "Change to types node." This reverts commit bfb8b7b. Co-authored-by: Andrew Duthie <andrew@andrewduthie.com> * [RNMobile] Dark mode on Android put on the v1.25.0 native release (#21352) * Revert revert of dark mode impl * Add pre to list of block wrappers (#21255) * Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase Co-authored-by: Marko Savic <savicmarko1985@gmail.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com> Co-authored-by: Andrew Duthie <andrew@andrewduthie.com> Co-authored-by: Stefanos Togoulidis <stefanostogoulidis@gmail.com> Co-authored-by: Marko Savic <savicmarko1985@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up from #21139, to bring Dark Mode on Android on top of the v1.25.0 release of the native block editor.
How has this been tested?
With this gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2098
Types of changes
Introduces the
usePreferredColorSchemehook to use with Dark Mode.Checklist: