Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm-package-json-lint from 4.0.3 to 5.0.0 #21597

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Apr 15, 2020

Description

In #21528, lint mysteriously failed with the message, 'Cannot read property 'toUpperCase' of undefined'. This PR fixes this problem.

The cause was the empty "description" field in package.json file. Check tclindner/npm-package-json-lint#163.

How has this been tested?

Manually tested. And it now passes.

Screenshots

N/A

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • [N/A] My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • [N/A] My code has proper inline documentation.
  • [N/A] I've included developer documentation if appropriate.
  • [N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

@ntwb
Copy link
Member

ntwb commented Apr 15, 2020

Thanks @sainthkh, none of the new rules in 4.3 or newer requiring setting up, bumping to v5 should not be an issue, I reviewed v5 and added a new rule to it just prior to the v5 release a few days ago, so it should be fine to bump to v5 instead of 4.1.x

@gziolo
Copy link
Member

gziolo commented Apr 15, 2020

Can you also include a note in the CHANGELOG file:
https://github.com/WordPress/gutenberg/blob/master/packages/scripts/CHANGELOG.md

Ideally, with the link that has all the changes introduced. If nothing breaks on our side, we can keep it as a minor version bump.

@gziolo gziolo added the [Package] Scripts /packages/scripts label Apr 15, 2020
@sainthkh
Copy link
Contributor Author

We don't have any related breaking change in npm-package-json-lint.

So, I've written the change under Bug Fix section.

@sainthkh sainthkh changed the title Update npm-package-json-lint from 4.0.3 to 4.1.1. Update npm-package-json-lint from 4.0.3 to 5.0.0 Apr 15, 2020
@sainthkh sainthkh force-pushed the update/npm-package-json-lint branch from e78c2b9 to f3288bf Compare April 15, 2020 11:25
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @sainthkh, for addressing our feedback 💯

@gziolo gziolo merged commit e3818fb into WordPress:master Apr 15, 2020
@github-actions github-actions bot added this to the Gutenberg 8.0 milestone Apr 15, 2020
@gziolo
Copy link
Member

gziolo commented Apr 15, 2020

@youknowriad, can you promote @sainthkh to the member role in the repository. He has already a few landed meaningful contributions and some great work in the review process.

@youknowriad
Copy link
Contributor

done. Thanks for your work @sainthkh

@sainthkh
Copy link
Contributor Author

@gziolo @youknowriad Thanks. I'm honored to become a member.

@aduth
Copy link
Member

aduth commented Apr 16, 2020

It's well-deserved 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants