Post title: handle paste as blocks #21758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
|
Size Change: +242 B (0%) Total Size: 842 kB
ℹ️ View Unchanged
|
youknowriad
reviewed
Apr 22, 2020
| onInsertBlockAfter( content ); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you think there's logic to be shared between this and the other place we're using it today (RichText?)?
There was a problem hiding this comment.
I think as soon as we turn the title into a block a few things would have to be consolidated.
There was a problem hiding this comment.
Right, there is logic that can be shared, but we should instead aim to turn the post title into a block, which means the logic will automatically be shared through either RichText or PlainText v2.
mapk
approved these changes
Apr 23, 2020
|
Let's merge this and iterate. I was looking at e2e tests quick, but we need to emulate all clipboard behaviour on textarea and I didn't get it to work immediately. |
|
Thanks @ellatrix ! Love these small quality-of-life improvements :) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles pasting in the post title (post editor) a bit better. Before everything would be pasted inline as the title, now we parse the pasted content as blocks and paste the block after the title. If the first block is a heading or a paragraph AND the title is empty, the content of this first block will be used for the title. I've left out more complex splitting, for example when there would be already text in the title and the selection is in the middle. Ideally we should be using RichText or PlainText version 2 for the post title, which has built in splitting and paste handling, but in order to use this, the post title should be a real block... which I think we plan to do at some point? I recall having run into problems with the post title block a few times now because it's not a real block, especially with writing flow. Cc @youknowriad @mtias.
To do: maybe add some e2e tests.
How has this been tested?
Paste a few blocks of text from a page into the post title. Also try to paste a small string of text, try with title already filled in etc.
Screenshots
Types of changes
Enhancement
Checklist: