Fix extra tab stop on Modal component #22063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Focus] Accessibility (a11y)
tellthemachines
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: -3.3 kB (0%) Total Size: 822 kB
ℹ️ View Unchanged
|
tellthemachines
changed the title
talldan
approved these changes
May 7, 2020
There was a problem hiding this comment.
I gave this a test. I think the positive is that the dialog element is focused initially and the title of the modal is read in voiceover. The close button can now be tabbed to after initially opening the modal.
I think it might be a bit unexpected that there's an element that's focused initially which after tabbing is removed from the tab order, but it still seems to be a good improvement over how it works currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11631.
Currently, on VoiceOver with Safari, pressing arrow keys inside a modal will cause the modal to close, because focus is moved outside the modal. Changing the order of the HOCs wrappingModalFrameso thatwithConstrainedTabbingis inside ofwithFocusOutsidefixes the issue.Update: the fix for focus moving outside the modal on VoiceOver wasn't working properly so I'm focusing this PR on fixing the extra tab stop issue. Thanks @talldan for helping debug this 😄
This PR removes the
tabindex=0fromcomponents-modal__contentand directs focus to land oncomponents-modal__frameinstead, as it already has atabindex=-1and it is labelled by the modal header, so is more informative to screen readers. The element withtabindex=0was causing an extra, unidentified tab stop between the last focusable element of the modal and the first, when tabbing through cyclically.How has this been tested?
Checked on Safari + VoiceOver on Mac, Firefox + NVDA on Windows, and checked just the keyboard interaction across several browsers.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: