Add "black" and "white" color options to default color palette. #22082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes other intermediary grays from the UI but keeps them in the CSS declarations as classes for back-compat.
mtias
added
Customization
mtias
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
|
Size Change: +54 B (0%) Total Size: 819 kB
ℹ️ View Unchanged
|
What happens when one of the previous colors we are deprecating is used is that the block keeps the color in the editor and frontend but none of the current colors we have appear as selected (as the select color is now not available). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add black and white as default color options since they have ubiquitous use and value for more accessible color contrast with the widest variety of colors:
To keep the palette balanced this change also drops some of the intermediary grays from the UI — they are kept, though, in the CSS declaration to ensure the CSS can still be applied. Need to revise if a former class being set causes any issues in the UI when loaded again cc @jorgefilipecosta