Block patterns categories follow-up #22410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Feature] Patterns
swissspidy
reviewed
May 18, 2020
| register_block_pattern_category( 'text', array( 'label' => __( 'Text', 'gutenberg' ) ) ); | ||
| register_block_pattern_category( 'hero', array( 'label' => __( 'Hero', 'gutenberg' ) ) ); | ||
| register_block_pattern_category( 'text', array( 'label' => _x( 'Text', 'Block pattern category', 'gutenberg' ) ) ); | ||
| register_block_pattern_category( 'hero', array( 'label' => _x( 'Hero', 'Block pattern category', 'gutenberg' ) ) ); |
There was a problem hiding this comment.
Why only add the context to these two categories? I'd add them to all for consistency.
There was a problem hiding this comment.
I didn't know whether you meant all or just these two originally. The downside is the potential string duplication. I'll update
|
Size Change: +1 B Total Size: 835 kB
ℹ️ View Unchanged
|
2 tasks
aduth
approved these changes
May 18, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some follow-up issues raised after the merge of #22164
#22164 (review)
#22164 (review)
#22164 (review)