Block Library: Remove redundant condition from setting default grouping #22563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Code Quality
aduth
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
Merged
5 tasks
|
Size Change: -1 B Total Size: 1.12 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #15774 (comment)
This pull request seeks to remove a redundant condition which checks for truthiness of the
groupimported variable before assigning it as the default grouping handler block. There is no case in which the resolvedimportassigning thegroupvariable could ever be falsey. As such, the condition should be removed, as it will always match.Testing Instructions:
Repeat testing instructions from #15774