New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Remove Keyboard.dismiss when deleting block #22677
Conversation
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this, on iOS and Android, by adding and deleting all blocks available and it worked well for me.
Let's just have @mchowning double-check before we merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Android and I don't see any issues. Thanks @lukewalczak ! 🙇
Description
Remove the line with
Keyboard.dismiss()
which could be the cause of crash on Android when newly added block such as:Media&Text
,Contact Info
It can fix: wordpress-mobile/WordPress-Android#10491
Ref to gutenberg mobile: wordpress-mobile/gutenberg-mobile#2327
How has this been tested?
Media&Text
,ContactInfo
or any blockMedia&Text
blockScreenshots
Types of changes
Checklist: