Remove ifBlockEditSelected internal higher-order component #22905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Performance
aduth
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
aduth
added
the
Good First Review
|
Size Change: +464 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jun 4, 2020
|
The end-to-end tests illustrate a legitimate issue, which is that the previous implementation would pass along
It could depend on a few things:
|
|
I think we should just pass |
|
Updated in e6e03c9 to pass only |
|
The only place where props are passed to It doesn't look like there is anything passed down really. It looks not needed. I agree that using |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to remove the
ifBlockEditSelectedinternal helper of the@wordpress/block-editorpackage. The motivation here is (a) to flatten the common block React element hierarchy and (b) to favor hooks-based implementations over higher-order components.ifBlockEditSelectedwas a useful and expressive helper at the time it was originally implemented, due to the cumbersome nature of using React Context<Consumer>elements. WithuseContext, it's much simpler now to get direct access to the context object properties relevant for this behavior. For some affected components, it's arguably still more verbose than the previous implementation, but it seems like a reasonable compromise. A flattened element hierarchy may bring some improved performance and debugging benefit.Testing Instructions:
Verify no regressions in the behavior of affected components. For example, block toolbar and inspector controls should only appear for the selected block.