Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts: Fix style.css handling in the build and start commands #23127

Merged
merged 5 commits into from
Jun 15, 2020
Merged

Scripts: Fix style.css handling in the build and start commands #23127

merged 5 commits into from
Jun 15, 2020

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jun 12, 2020 •
edited
Loading

Description

Fixes #22776.

Major props to @Ocean9, @ryelle and @nerrad for their help and prior art I could use for the proposed fix 🙇

It's late here so I will add more details another day :)

How has this been tested?

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • [n/a] I've updated all React Native files affected by any refactorings/renamings in this PR.

@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Package] Scripts /packages/scripts [Package] Create Block /packages/create-block labels Jun 12, 2020
@gziolo gziolo requested review from ryelle and ocean90 June 12, 2020 23:14
@gziolo gziolo self-assigned this Jun 12, 2020
@gziolo gziolo force-pushed the fix/wp-scripts-build-style branch from e2edebd to 7880d38 Compare June 12, 2020 23:17
@gziolo gziolo mentioned this pull request Jun 12, 2020
Closed
@github-actions
Copy link

github-actions bot commented Jun 12, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.22 kB 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-editor/index.js 106 kB 0 B
build/block-editor/style-rtl.css 12.1 kB 0 B
build/block-editor/style.css 12.1 kB 0 B
build/block-library/editor-rtl.css 7.88 kB 0 B
build/block-library/editor.css 7.89 kB 0 B
build/block-library/index.js 129 kB 0 B
build/block-library/style-rtl.css 7.96 kB 0 B
build/block-library/style.css 7.96 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 195 kB 0 B
build/components/style-rtl.css 19.5 kB 0 B
build/components/style.css 19.5 kB 0 B
build/compose/index.js 9.32 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.17 kB 0 B
build/edit-navigation/index.js 8.26 kB 0 B
build/edit-navigation/style-rtl.css 975 B 0 B
build/edit-navigation/style.css 974 B 0 B
build/edit-post/index.js 302 kB 0 B
build/edit-post/style-rtl.css 5.6 kB 0 B
build/edit-post/style.css 5.6 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/index.js 9.34 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/editor-styles-rtl.css 423 B 0 B
build/editor/editor-styles.css 423 B 0 B
build/editor/index.js 44.8 kB 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.13 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

ocean90
ocean90 approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good and it's working for me! Also tested with a custom webpack config with different entry points.

.wp-env.json Outdated Show resolved Hide resolved
packages/scripts/README.md Outdated Show resolved Hide resolved
@gziolo gziolo force-pushed the fix/wp-scripts-build-style branch 3 times, most recently from 3fbc6cb to 589443a Compare June 13, 2020 21:01
@ocean90 ocean90 mentioned this pull request Jun 14, 2020
Closed
@gziolo gziolo force-pushed the fix/wp-scripts-build-style branch from ee03e31 to 990ae3f Compare June 15, 2020 06:55
@gziolo gziolo merged commit 567b159 into master Jun 15, 2020
@gziolo gziolo deleted the fix/wp-scripts-build-style branch June 15, 2020 07:44
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 15, 2020
@gziolo gziolo modified the milestones: Gutenberg 8.4, Gutenberg 8.3 Jun 15, 2020
@gziolo gziolo added this to the Gutenberg 8.4 milestone Jun 15, 2020
oandregal pushed a commit that referenced this pull request Jun 15, 2020
@gziolo @ocean90 @oandregal
Scripts: Fix style.css handling in the build and start commands (#23127)
592578a 
* Scripts: Fix style.css handling in the build and start commands

* Scripts: Fix style.css handling in the build and start commands

* Docs: Add changelog entry

* Update packages/scripts/config/webpack.config.js

Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>

* Docs: Add tweaks to the CSS support description

Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
This was referenced Jun 24, 2020
Closed
Merged
@gziolo gziolo mentioned this pull request Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocean90 ocean90 ocean90 approved these changes

@ryelle ryelle Awaiting requested review from ryelle

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

Assignees

@gziolo gziolo

Labels
[Package] Create Block /packages/create-block [Package] Scripts /packages/scripts [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.4
Development

Successfully merging this pull request may close these issues.

importing style.(c/sc)ss with @wordpress/scripts 10.0 causes JavaScript to stop running?
2 participants
@gziolo @ocean90