Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change select parent button styles #23230

Merged
merged 1 commit into from Jun 17, 2020
Merged

Change select parent button styles #23230

merged 1 commit into from Jun 17, 2020

Conversation

ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Jun 17, 2020 •
edited

Description

Fixes #22723

This is a small CSS fix for select parent button where the button's click space was not filling the button itself.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

youknowriad
youknowriad approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little simplification here. Thanks.

The e2e tests are unrelated and I'm working on fixing them.

@youknowriad youknowriad merged commit cd07005 into WordPress:master Jun 17, 2020
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 17, 2020
@ntsekouras ntsekouras deleted the fix/select-parent-button-style branch June 17, 2020 08:44
@diegohaz diegohaz mentioned this pull request Jun 17, 2020
Merged
This was referenced Jun 24, 2020
Closed
Merged
@mapk
Copy link
Contributor

mapk commented Jun 29, 2020

🎉 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 8.4
Development

Successfully merging this pull request may close these issues.

Mahjong parent tile block selector doesn't use the same click space as other icons
3 participants
@ntsekouras @mapk @youknowriad