New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keywords to various blocks for easier discovery. #2336
Conversation
blocks/library/latest-posts/index.js
Outdated
@@ -33,6 +33,8 @@ registerBlockType( 'core/latest-posts', { | |||
|
|||
category: 'widgets', | |||
|
|||
keywords: [ __( 'recent-posts' ) ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious about this, why did you use recent-posts
instead of recent posts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought spaces wouldn't work, otherwise 'recent posts'
would signal you can do 'tagA tagB tagC ... tagN'
and circumvent the 3 keywords max :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you search for tagB
it won't work. but it's the same if it was tagA-tagB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, kind of pointless.
Nice! I think it'd be good to get this in and then it can always be iterated further. Some quick thoughts:
|
Codecov Report
@@ Coverage Diff @@
## master #2336 +/- ##
==========================================
- Coverage 24.78% 24.66% -0.13%
==========================================
Files 151 152 +1
Lines 4721 4744 +23
Branches 799 800 +1
==========================================
Hits 1170 1170
- Misses 2997 3019 +22
- Partials 554 555 +1
Continue to review full report at Codecov.
|
Awesome! |
Help with searching.