Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords to various blocks for easier discovery. #2336

Merged
merged 3 commits into from Aug 10, 2017

Conversation

mtias
Copy link
Member

@mtias mtias commented Aug 10, 2017

Help with searching.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Aug 10, 2017
@@ -33,6 +33,8 @@ registerBlockType( 'core/latest-posts', {

category: 'widgets',

keywords: [ __( 'recent-posts' ) ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this, why did you use recent-posts instead of recent posts

Copy link
Member Author

@mtias mtias Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought spaces wouldn't work, otherwise 'recent posts' would signal you can do 'tagA tagB tagC ... tagN' and circumvent the 3 keywords max :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you search for tagB it won't work. but it's the same if it was tagA-tagB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, kind of pointless.

@jasmussen
Copy link
Contributor

Nice! I think it'd be good to get this in and then it can always be iterated further. Some quick thoughts:

  • Should we add "header" to the "Heading" also? I know in the future we'll have an actual Header block, but in this case you'd just get two search results right?
  • Should we add both "photo" and "photos" to the gallery and image blocks?

@codecov
Copy link

codecov bot commented Aug 10, 2017

Codecov Report

Merging #2336 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
- Coverage   24.78%   24.66%   -0.13%     
==========================================
  Files         151      152       +1     
  Lines        4721     4744      +23     
  Branches      799      800       +1     
==========================================
  Hits         1170     1170              
- Misses       2997     3019      +22     
- Partials      554      555       +1
Impacted Files Coverage Δ
blocks/library/gallery/index.js 25% <ø> (ø) ⬆️
blocks/library/separator/index.js 50% <ø> (ø) ⬆️
blocks/library/embed/index.js 45.45% <ø> (ø) ⬆️
blocks/library/image/index.js 12.24% <ø> (ø) ⬆️
blocks/library/latest-posts/index.js 10% <ø> (ø) ⬆️
blocks/library/list/index.js 7.22% <ø> (ø) ⬆️
blocks/library/heading/index.js 23.8% <ø> (ø) ⬆️
blocks/library/cover-text/index.js 35% <ø> (ø) ⬆️
editor/sidebar/post-status/index.js 0% <0%> (ø) ⬆️
editor/sidebar/post-format/index.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60001ba...4631a14. Read the comment docs.

@mtias mtias merged commit 4cc2e9e into master Aug 10, 2017
@mtias mtias deleted the add/many-block-keywords branch August 10, 2017 13:57
@melchoyce
Copy link
Contributor

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants