Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Tag Cloud block to use React Hooks #23426

Merged
merged 2 commits into from Jul 17, 2020
Merged

Refactor Tag Cloud block to use React Hooks #23426

merged 2 commits into from Jul 17, 2020

Conversation

bartczyz
Copy link
Contributor

Description

Related #22890.

Types of changes

Refactor TagCloudEdit to use React Hooks.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ZebulanStanphill ZebulanStanphill added [Block] Tag Cloud Affects the Tag Cloud Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality labels Jun 25, 2020
youknowriad
youknowriad reviewed Jun 29, 2020
View reviewed changes
packages/block-library/src/tag-cloud/edit.js

this.state = {
editing: ! this.props.attributes.taxonomy,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this was useless

@youknowriad
Copy link
Contributor

Would you mind rebasing the PR to get the latest checks?

@bartczyz
Copy link
Contributor Author

@youknowriad sure, no problem. 🙂

@ZebulanStanphill ZebulanStanphill merged commit 0a22d69 into WordPress:master Jul 17, 2020
@github-actions github-actions bot added this to the Gutenberg 8.6 milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ZebulanStanphill ZebulanStanphill ZebulanStanphill approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@ajlende ajlende Awaiting requested review from ajlende

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@ellatrix ellatrix Awaiting requested review from ellatrix

@etoledom etoledom Awaiting requested review from etoledom

@gziolo gziolo Awaiting requested review from gziolo

@karmatosed karmatosed Awaiting requested review from karmatosed

@mapk mapk Awaiting requested review from mapk

@mkaz mkaz Awaiting requested review from mkaz

@mkevins mkevins Awaiting requested review from mkevins

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@pinarol pinarol Awaiting requested review from pinarol

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
[Block] Tag Cloud Affects the Tag Cloud Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 8.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartczyz @youknowriad @ZebulanStanphill