Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "caption" styles in images and embeds to the front-end. #2345

Merged
merged 1 commit into from Aug 10, 2017

Conversation

mtias
Copy link
Member

@mtias mtias commented Aug 10, 2017

Make sure these arrive on the front end and are explicit:

image

@mtias mtias added [Feature] Blocks Overall functionality of blocks Customization Issues related to Phase 2: Customization efforts labels Aug 10, 2017
@mtias mtias requested a review from karmatosed August 10, 2017 13:55
@mtias mtias force-pushed the add/caption-front-end-styles branch from 6670c87 to 815f0b8 Compare August 10, 2017 13:55
@mtias
Copy link
Member Author

mtias commented Aug 10, 2017

@karmatosed a theme would overwrite these with .wp-block-image figcaption {}.

@codecov
Copy link

codecov bot commented Aug 10, 2017

Codecov Report

Merging #2345 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
- Coverage   24.69%   24.63%   -0.07%     
==========================================
  Files         152      152              
  Lines        4738     4949     +211     
  Branches      799      847      +48     
==========================================
+ Hits         1170     1219      +49     
- Misses       3014     3132     +118     
- Partials      554      598      +44
Impacted Files Coverage Δ
blocks/library/embed/index.js 48.36% <ø> (+2.91%) ⬆️
blocks/library/image/index.js 12.04% <ø> (-0.2%) ⬇️
blocks/library/separator/index.js 42.85% <0%> (-7.15%) ⬇️
blocks/library/cover-text/index.js 29.41% <0%> (-5.59%) ⬇️
blocks/library/heading/index.js 18.91% <0%> (-4.9%) ⬇️
blocks/library/latest-posts/index.js 7.22% <0%> (-2.78%) ⬇️
blocks/library/gallery/index.js 23.8% <0%> (-1.2%) ⬇️
blocks/library/list/index.js 6.72% <0%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ddb89f...815f0b8. Read the comment docs.

@mtias mtias merged commit 31879c2 into master Aug 10, 2017
@mtias mtias deleted the add/caption-front-end-styles branch August 10, 2017 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customization Issues related to Phase 2: Customization efforts [Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants