Gallery: Update button rendering (Move backward, Move forward, Remove) #23471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
added
[Type] Bug
|
Size Change: +678 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Jun 26, 2020
|
@ellatrix I can't recall, but it think that maybe by design - at least, based on the previously defined styles. cc'ing @jasmussen |
|
It's not directly intentional, it's more of ensuring a decent overall balance until such a time as we can replace the gallery block with one that simply nests image blocks inside (every you'd get the mover for free). In that vein, the buttons just need to be at least 24x24 and it's fine. You could replace the big close icon with the recently merged "closeSmall", for a better balance. |
|
@jasmussen Thank you for your thoughts! I just checked and the buttons are 24x24. I replaced the
|
|
Ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the Move backward, Move forwarded, and Remove button rendering for the Gallery block.
The issue seemed to come from some newer styles overridding the padding resets of the Gallery buttons.
The solution involved increasing the specificity of the Gallery button selectors.
How has this been tested?
npm run dev(Test in Chrome, Safari, and Firefox)
Checklist:
Resolves: #23469