Update the editor landmark regions #24196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Focus] Accessibility (a11y)
|
Size Change: +460 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Jul 27, 2020
youknowriad
force-pushed
the
update/editor-landmark-regions
branch
from
0720a23
to
64437b0
Compare
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
youknowriad
added a commit
that referenced
this pull request
Jul 27, 2020
youknowriad
removed
the
Backport to WP 6.6 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21715
It's arguable whether the names should change between screens. IMO if the application layout stays similar across screens (post editor, site editor, widgets, and potentially more to come), the names might be better chose as generic names.
That said, since at the moment we only have the Editor screen in production, I'm fine reverting the change.