Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cloning nodes and clunky tests by passing pasted HTML string #2479

Merged
merged 1 commit into from Aug 20, 2017

Conversation

ellatrix
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 20, 2017

Codecov Report

Merging #2479 into master will increase coverage by 0.13%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2479      +/-   ##
==========================================
+ Coverage   26.88%   27.01%   +0.13%     
==========================================
  Files         158      159       +1     
  Lines        4892     5086     +194     
  Branches      814      870      +56     
==========================================
+ Hits         1315     1374      +59     
- Misses       3034     3131      +97     
- Partials      543      581      +38
Impacted Files Coverage Δ
blocks/editable/index.js 11.06% <0%> (-0.05%) ⬇️
blocks/api/paste/strip-attributes.js 100% <100%> (ø) ⬆️
blocks/api/paste/index.js 100% <100%> (ø) ⬆️
blocks/api/paste/strip-wrappers.js 100% <100%> (ø) ⬆️
blocks/api/paste/normalise-blocks.js 96.87% <100%> (+0.2%) ⬆️
editor/header/saved-state/index.js 75% <0%> (-10.72%) ⬇️
blocks/library/heading/index.js 18.91% <0%> (-4.9%) ⬇️
editor/modes/visual-editor/block.js 0% <0%> (ø) ⬆️
blocks/inspector-controls/select-control/index.js 0% <0%> (ø) ⬆️
blocks/color-palette/index.js 0% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a99994...eee0879. Read the comment docs.

@ellatrix
Copy link
Member Author

Merging so we can move on with other paste PRs. This should simplify adding paste filters and tests.

@ellatrix ellatrix merged commit 5125ee1 into master Aug 20, 2017
@ellatrix ellatrix deleted the try/paste-pass-HTML branch August 20, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant